prefer-math-min-max: Ignore Date objects (#2903)

costajohnt · web-flow · commit cd53d9eaa952 · 2026-03-19T19:10:17.000+07:00
diff --git a/rules/prefer-math-min-max.js b/rules/prefer-math-min-max.js
@@ -1,5 +1,5 @@
 /* eslint-disable complexity */
-import {isBigIntLiteral, isCallExpression} from './ast/index.js';
+import {isBigIntLiteral, isCallExpression, isNewExpression} from './ast/index.js';
 import {fixSpaceAroundKeyword} from './fix/index.js';
 
 const MESSAGE_ID = 'prefer-math-min-max';
@@ -58,6 +58,12 @@ const create = context => {
 			return;
 		}
 
+		const hasDate = [left, right].some(node => isNewExpression(node, {name: 'Date'}));
+
+		if (hasDate) {
+			return;
+		}
+
 		const [leftText, rightText, alternateText, consequentText] = [left, right, alternate, consequent].map(node => getExpressionText(node, context.sourceCode));
 
 		const isGreaterOrEqual = operator === '>' || operator === '>=';
@@ -158,6 +164,17 @@ const create = context => {
 								return;
 							}
 
+							/**
+							Capture the following statement
+
+							```js
+							var foo = new Date()
+							```
+							*/
+							if (isNewExpression(variableDeclarator.init, {name: 'Date'})) {
+								return;
+							}
+
 							break;
 						}
 
diff --git a/test/prefer-math-min-max.js b/test/prefer-math-min-max.js
@@ -13,6 +13,19 @@ test.snapshot({
 		'foo > 10n ? 10n : foo',
 		'foo > BigInt(10) ? BigInt(10) : foo',
 
+		// Ignore Date objects
+		'new Date() > foo ? foo : new Date()',
+		'foo > new Date(0) ? new Date(0) : foo',
+		outdent`
+			var now = new Date();
+			var later = new Date();
+			var value = now > later ? later : now;
+		`,
+		outdent`
+			const start = new Date();
+			var value = start > foo ? foo : start;
+		`,
+
 		// Ignore when you know it is a string
 		outdent`
 			function foo(a = 'string', b) {
@@ -118,6 +131,16 @@ test.snapshot({
 				return a > b ? a : b;
 			}
 		`,
+		outdent`
+			function foo(a: Date, b: Date) {
+				return a > b ? a : b;
+			}
+		`,
+		outdent`
+			var foo: Date;
+			var bar: Date;
+			var value = foo > bar ? bar : foo;
+		`,
 		outdent`
 			var foo = 10;
 			var bar = '20';
