Rename no-array-for-each rule to no-for-each (#3216)

sindresorhus · web-flow · commit b87c8a9e9ddf · 2026-06-14T10:39:27.000+02:00
diff --git a/AGENTS.md b/AGENTS.md
@@ -181,7 +181,7 @@ Use a clear prefix that signals intent (see [ESLint built-in rules](https://esli
 - **`consistent-`** - Enforce a single consistent style: `consistent-destructuring`
 - **No prefix** - Enforce a specific pattern: `error-message`, `filename-case`, `throw-new-error`
 
-Name after the target construct, not the fix. Be specific: `no-array-for-each` not `no-foreach`.
+Name after the target construct, not the fix. Be specific: `no-array-method-this-argument` not `no-this-argument`.
 
 ## Creating a new rule
 
diff --git a/docs/rules/no-for-each.md b/docs/rules/no-for-each.md
@@ -1,4 +1,4 @@
-# no-array-for-each
+# no-for-each
 
 📝 Prefer `for…of` over the `forEach` method.
 
diff --git a/eslint.dogfooding.config.js b/eslint.dogfooding.config.js
@@ -63,7 +63,7 @@ const config = [
 		files: [
 			'rules/comment-content.js',
 			'rules/consistent-assert.js',
-			'rules/no-array-for-each.js',
+			'rules/no-for-each.js',
 			'rules/no-array-reduce.js',
 			'rules/no-declarations-before-early-exit.js',
 			'rules/no-error-property-assignment.js',
diff --git a/readme.md b/readme.md
@@ -94,7 +94,6 @@ export default [
 | [no-anonymous-default-export](docs/rules/no-anonymous-default-export.md)                                   | Disallow anonymous functions and classes as the default export.                                                                | ✅ ☑️ |    | 💡 |
 | [no-array-callback-reference](docs/rules/no-array-callback-reference.md)                                   | Prevent passing a function reference directly to iterator methods.                                                             | ✅    |    | 💡 |
 | [no-array-fill-with-reference-type](docs/rules/no-array-fill-with-reference-type.md)                       | Disallow using reference values as `Array#fill()` values.                                                                      | ✅ ☑️ |    |    |
-| [no-array-for-each](docs/rules/no-array-for-each.md)                                                       | Prefer `for…of` over the `forEach` method.                                                                                     | ✅ ☑️ | 🔧 | 💡 |
 | [no-array-from-fill](docs/rules/no-array-from-fill.md)                                                     | Disallow `.fill()` after `Array.from({length: …})`.                                                                            | ✅ ☑️ |    |    |
 | [no-array-method-this-argument](docs/rules/no-array-method-this-argument.md)                               | Disallow using the `this` argument in array methods.                                                                           | ✅ ☑️ | 🔧 | 💡 |
 | [no-array-reduce](docs/rules/no-array-reduce.md)                                                           | Disallow `Array#reduce()` and `Array#reduceRight()`.                                                                           | ✅    | 🔧 |    |
@@ -117,6 +116,7 @@ export default [
 | [no-empty-file](docs/rules/no-empty-file.md)                                                               | Disallow empty files.                                                                                                          | ✅ ☑️ |    |    |
 | [no-error-property-assignment](docs/rules/no-error-property-assignment.md)                                 | Disallow assigning to built-in error properties.                                                                               | ✅ ☑️ |    |    |
 | [no-exports-in-scripts](docs/rules/no-exports-in-scripts.md)                                               | Disallow exports in scripts.                                                                                                   | ✅ ☑️ |    |    |
+| [no-for-each](docs/rules/no-for-each.md)                                                                   | Prefer `for…of` over the `forEach` method.                                                                                     | ✅ ☑️ | 🔧 | 💡 |
 | [no-for-loop](docs/rules/no-for-loop.md)                                                                   | Do not use a `for` loop that can be replaced with a `for-of` loop.                                                             | ✅    | 🔧 |    |
 | [no-global-object-property-assignment](docs/rules/no-global-object-property-assignment.md)                 | Disallow assigning properties on the global object.                                                                            | ✅ ☑️ |    |    |
 | [no-immediate-mutation](docs/rules/no-immediate-mutation.md)                                               | Disallow immediate mutation after variable assignment.                                                                         | ✅    | 🔧 | 💡 |
diff --git a/rules/index.js b/rules/index.js
@@ -35,7 +35,6 @@ export {default as 'no-accessor-recursion'} from './no-accessor-recursion.js';
 export {default as 'no-anonymous-default-export'} from './no-anonymous-default-export.js';
 export {default as 'no-array-callback-reference'} from './no-array-callback-reference.js';
 export {default as 'no-array-fill-with-reference-type'} from './no-array-fill-with-reference-type.js';
-export {default as 'no-array-for-each'} from './no-array-for-each.js';
 export {default as 'no-array-from-fill'} from './no-array-from-fill.js';
 export {default as 'no-array-method-this-argument'} from './no-array-method-this-argument.js';
 export {default as 'no-array-reduce'} from './no-array-reduce.js';
@@ -58,6 +57,7 @@ export {default as 'no-duplicate-set-values'} from './no-duplicate-set-values.js
 export {default as 'no-empty-file'} from './no-empty-file.js';
 export {default as 'no-error-property-assignment'} from './no-error-property-assignment.js';
 export {default as 'no-exports-in-scripts'} from './no-exports-in-scripts.js';
+export {default as 'no-for-each'} from './no-for-each.js';
 export {default as 'no-for-loop'} from './no-for-loop.js';
 export {default as 'no-global-object-property-assignment'} from './no-global-object-property-assignment.js';
 export {default as 'no-immediate-mutation'} from './no-immediate-mutation.js';
diff --git a/rules/no-for-each.js b/rules/no-for-each.js
@@ -30,8 +30,8 @@ import {
 	assertToken,
 } from './utils/index.js';
 
-const MESSAGE_ID_ERROR = 'no-array-for-each/error';
-const MESSAGE_ID_SUGGESTION = 'no-array-for-each/suggestion';
+const MESSAGE_ID_ERROR = 'no-for-each/error';
+const MESSAGE_ID_SUGGESTION = 'no-for-each/suggestion';
 const messages = {
 	[MESSAGE_ID_ERROR]: 'Use `for…of` instead of `.forEach(…)`.',
 	[MESSAGE_ID_SUGGESTION]: 'Switch to `for…of`.',
@@ -134,7 +134,7 @@ function getFixFunction(callExpression, functionInfo, context) {
 		const returnToken = sourceCode.getFirstToken(returnStatement);
 		assertToken(returnToken, {
 			expected: 'return',
-			ruleId: 'no-array-for-each',
+			ruleId: 'no-for-each',
 		});
 
 		if (!returnStatement.argument) {
diff --git a/test/no-for-each.js b/test/no-for-each.js
diff --git a/test/snapshots/no-for-each.js.md b/test/snapshots/no-for-each.js.md
@@ -1,6 +1,6 @@
-# Snapshot report for `test/no-array-for-each.js`
+# Snapshot report for `test/no-for-each.js`
 
-The actual snapshot is saved in `no-array-for-each.js.snap`.
+The actual snapshot is saved in `no-for-each.js.snap`.
 
 Generated by [AVA](https://avajs.dev).
 
diff --git a/test/snapshots/no-for-each.js.snap b/test/snapshots/no-for-each.js.snap

Original file line number	Diff line number	Diff line change
`@@ -1,4 +1,4 @@`
`1`		`-# no-array-for-each`
	`1`	`+# no-for-each`
`2`	`2`
`3`	`3`	📝 Prefer `for…of` over the `forEach` method.
`4`	`4`