Skip to content

Increase default HTTP idle timeout#1287

Merged
Hayden-IO merged 1 commit into
sigstore:mainfrom
jku:increase-idle-timout
Jan 29, 2026
Merged

Increase default HTTP idle timeout#1287
Hayden-IO merged 1 commit into
sigstore:mainfrom
jku:increase-idle-timout

Conversation

@jku

@jku jku commented Jan 29, 2026

Copy link
Copy Markdown
Member

Add "--cleanup-timeout" to expose the knob and set the default to 620 seconds (to make the defaults nice for GCP deployment).

From GCP load balancing docs:

The load balancer's backend keepalive timeout must be less than the keepalive timeout used by software running on your backends. This avoids a race condition where the operating system of your backends might close TCP connections with a TCP reset (RST). Because the backend keepalive timeout for the load balancer isn't configurable, you must configure your backend software so that its HTTP keepalive (TCP idle) timeout value is greater than 600 seconds.

Fixes #1286

@jku jku requested a review from a team as a code owner January 29, 2026 18:05
@codecov

codecov Bot commented Jan 29, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 0% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 17.12%. Comparing base (6fd19b0) to head (9422335).
⚠️ Report is 569 commits behind head on main.

Files with missing lines Patch % Lines
cmd/timestamp-server/app/serve.go 0.00% 2 Missing ⚠️
cmd/timestamp-server/app/root.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##             main    #1287       +/-   ##
===========================================
- Coverage   52.85%   17.12%   -35.74%     
===========================================
  Files          20       55       +35     
  Lines        1209     3072     +1863     
===========================================
- Hits          639      526      -113     
- Misses        509     2493     +1984     
+ Partials       61       53        -8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@jku

jku commented Jan 29, 2026

Copy link
Copy Markdown
Member Author

oops did not realize that's a generated file

@jku jku marked this pull request as draft January 29, 2026 18:08
Add "--cleanup-timeout" to expose the knob and set the
default to 620 seconds (to make the defaults nice for
GCP deployment).

For reference, GCP load balancing docs:

The load balancer's backend keepalive timeout must be less than the
keepalive timeout used by software running on your backends. This
avoids a race condition where the operating system of your backends
might close TCP connections with a TCP reset (RST). Because the backend
keepalive timeout for the load balancer isn't configurable, you must
configure your backend software so that its HTTP keepalive (TCP idle)
timeout value is greater than 600 seconds.

Signed-off-by: Jussi Kukkonen <jkukkonen@google.com>
@jku jku force-pushed the increase-idle-timout branch from 5f6efa4 to 9422335 Compare January 29, 2026 18:26
@jku jku marked this pull request as ready for review January 29, 2026 18:29
@Hayden-IO Hayden-IO merged commit ef75de2 into sigstore:main Jan 29, 2026
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

potential idle timeout conflict

2 participants