Stop depending on golang.org/x/crypto for sha3#2209
Merged
Hayden-IO merged 1 commit intosigstore:mainfrom Nov 12, 2025
Merged
Conversation
Contributor
|
I don't see any usage of sha3 in the code base. Can we remove this instead? |
Nothing in this module refers to sha3 hashes, so there seems to be no reason to trigger registering an implementation. Signed-off-by: Miloslav Trmač <mitr@redhat.com>
Contributor
Author
|
Sure, done. |
Hayden-IO
approved these changes
Nov 12, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
As of Go 1.24, crypto/sha3 exists in the standard library, so we can depend on it directly to register an implementation.And golang.org/x/crypto 0.44 replaces its implementation with one that forwards into crypto/sha3 and does not register its own - so the standard-library implementation will be used either way.Nothing in this repository requires sha3 to be registered, so don’t, and drop the dependency on that subpackage.
Release Note
NONE
Documentation
NONE