Skip to content

Drop redundant aws-sdk-go dependency in the e2e kms tests#2172

Merged
bobcallaway merged 1 commit intosigstore:mainfrom
alexandear-org:test/drop-aws-sdk-go-dependency
Oct 8, 2025
Merged

Drop redundant aws-sdk-go dependency in the e2e kms tests#2172
bobcallaway merged 1 commit intosigstore:mainfrom
alexandear-org:test/drop-aws-sdk-go-dependency

Conversation

@alexandear
Copy link
Contributor

Summary

This PR replaces github.com/aws/aws-sdk-go with the newer github.com/aws/aws-sdk-go-v2 in the KMS e2e tests. This change allows us to remove dependency on github.com/aws/aws-sdk-go.

Release Note

NONE

@alexandear alexandear requested review from a team as code owners October 7, 2025 16:27
Hayden-IO
Hayden-IO previously approved these changes Oct 7, 2025
Copy link
Contributor

@Hayden-IO Hayden-IO left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Signed-off-by: Oleksandr Redko <oleksandr.red+github@gmail.com>
@alexandear
Copy link
Contributor Author

Fixed e2e tests.

@bobcallaway bobcallaway enabled auto-merge (squash) October 8, 2025 12:13
@bobcallaway bobcallaway merged commit 2244a24 into sigstore:main Oct 8, 2025
16 checks passed
@alexandear alexandear deleted the test/drop-aws-sdk-go-dependency branch October 8, 2025 12:39
@alexandear
Copy link
Contributor Author

@bobcallaway Thanks for merging. Is it possible to create a new release with this change?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants