set GoogleAPIClientOption on GCP KMS provider#2128
Merged
bobcallaway merged 3 commits intosigstore:mainfrom Jul 29, 2025
Merged
set GoogleAPIClientOption on GCP KMS provider#2128bobcallaway merged 3 commits intosigstore:mainfrom
bobcallaway merged 3 commits intosigstore:mainfrom
Conversation
Member
|
need a rebase |
Signed-off-by: Bob Callaway <bcallaway@google.com>
6c176ca to
b993534
Compare
Member
Author
|
by pulling in the GCP option into |
Hayden-IO
reviewed
Jul 29, 2025
Contributor
Hayden-IO
left a comment
There was a problem hiding this comment.
I agree with you, also don't want to leak the GCP dependency into the other providers.
pkg/signature/options.go
Outdated
| ApplyRemoteVerification(*bool) | ||
| ApplyRPCAuthOpts(opts *options.RPCAuth) | ||
| ApplyKeyVersion(keyVersion *string) | ||
| ApplyGoogleAPIClientOption(opt *googleoption.ClientOption) |
Contributor
There was a problem hiding this comment.
Not my favorite idea, but could you have something like an ApplyKMSProviderOptions(opts []any) function and have each KMS provider type assert the options?
Signed-off-by: Bob Callaway <bcallaway@google.com>
Hayden-IO
approved these changes
Jul 29, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
this allows callers to set options when instantiating GCP KMS provider