Skip to content

fix: cliplugin: return ErrorProviderNotFound when calling Get with a path#1982

Merged
Hayden-IO merged 3 commits intosigstore:mainfrom
ramonpetgrave64:fix-provider-not-found-for-paths
Feb 17, 2025
Merged

fix: cliplugin: return ErrorProviderNotFound when calling Get with a path#1982
Hayden-IO merged 3 commits intosigstore:mainfrom
ramonpetgrave64:fix-provider-not-found-for-paths

Conversation

@ramonpetgrave64
Copy link
Copy Markdown
Contributor

@ramonpetgrave64 ramonpetgrave64 commented Feb 14, 2025 •
edited
Loading

Summary

Fixes #1979

Testing

Test against cosign

cd cosign
go mod edit -replace "github.com/sigstore/sigstore"="../sigstore"
go mod tidy
make test

sigstore CI tests pass.

Release Note

Changes kms.Get() to return a ProviderNotFoundError when the user supplies a filepath, or an input keyResourceID that cannot be parsed by [provider]://[key ref].

Documentation

No new documentation.

@ramonpetgrave64
return ErrorProviderNotFound when calling Get with a path
3eee669 
Signed-off-by: Ramon Petgrave <ramon.petgrave64@gmail.com>
@ramonpetgrave64
doc update
dcb74eb 
Signed-off-by: Ramon Petgrave <ramon.petgrave64@gmail.com>
@ramonpetgrave64 ramonpetgrave64 marked this pull request as ready for review February 14, 2025 19:37
@ramonpetgrave64 ramonpetgrave64 requested a review from a team as a code owner February 14, 2025 19:37
@ramonpetgrave64 ramonpetgrave64 mentioned this pull request Feb 14, 2025
Closed
@ramonpetgrave64
uodate test error message
bb6178e 
Signed-off-by: Ramon Petgrave <ramon.petgrave64@gmail.com>
@ramonpetgrave64 ramonpetgrave64 force-pushed the fix-provider-not-found-for-paths branch from 7c3f036 to bb6178e Compare February 14, 2025 19:44
Hayden-IO
Hayden-IO approved these changes Feb 14, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@Hayden-IO Hayden-IO left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems fine too, looks like an equivalent solution.

@ret2libc good with this?

@ret2libc
Copy link
Copy Markdown
Contributor

ret2libc commented Feb 17, 2025

@ret2libc good with this?

Good with it! Thanks @ramonpetgrave64

@Hayden-IO Hayden-IO merged commit ce0fa17 into sigstore:main Feb 17, 2025
16 checks passed
@PuneetPunamiya
Copy link
Copy Markdown
Contributor

PuneetPunamiya commented Feb 19, 2025

@haydentherapper any plans to gave a patch release with this fix anytime soon ?

@divyansh42 divyansh42 mentioned this pull request Feb 19, 2025
Closed
@Hayden-IO
Copy link
Copy Markdown
Contributor

Hayden-IO commented Feb 19, 2025

I cut a release.

@ramonpetgrave64 ramonpetgrave64 deleted the fix-provider-not-found-for-paths branch February 19, 2025 18:48
@ramonpetgrave64 ramonpetgrave64 restored the fix-provider-not-found-for-paths branch February 19, 2025 18:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Hayden-IO Hayden-IO Hayden-IO approved these changes

+1 more reviewer

@ret2libc ret2libc ret2libc approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

cliplugin changes break cosign tests

4 participants

@ramonpetgrave64 @ret2libc @PuneetPunamiya @Hayden-IO