cliplugin: add windows ci testing#1951
Merged
bobcallaway merged 15 commits intosigstore:mainfrom Feb 3, 2025
Merged
Conversation
Signed-off-by: Ramon Petgrave <ramon.petgrave64@gmail.com>
This reverts commit 54b1696. Signed-off-by: Ramon Petgrave <ramon.petgrave64@gmail.com>
Signed-off-by: Ramon Petgrave <ramon.petgrave64@gmail.com>
Signed-off-by: Ramon Petgrave <ramon.petgrave64@gmail.com>
Signed-off-by: Ramon Petgrave <ramon.petgrave64@gmail.com>
Signed-off-by: Ramon Petgrave <ramon.petgrave64@gmail.com>
Signed-off-by: Ramon Petgrave <ramon.petgrave64@gmail.com>
Signed-off-by: Ramon Petgrave <ramon.petgrave64@gmail.com>
Signed-off-by: Ramon Petgrave <ramon.petgrave64@gmail.com>
Signed-off-by: Ramon Petgrave <ramon.petgrave64@gmail.com>
Signed-off-by: Ramon Petgrave <ramon.petgrave64@gmail.com>
22 tasks
ramonpetgrave64
commented
Feb 3, 2025
| GO-FUZZ-BUILD := $(TOOLS_BIN_DIR)/go-fuzz-build | ||
|
|
||
| GOLANGCI_LINT_DIR = $(shell pwd)/bin | ||
| GOLANGCI_LINT_DIR = $(CURDIR)/bin |
Contributor
Author
There was a problem hiding this comment.
This built-in variable is os-independent.
loosebazooka
approved these changes
Feb 3, 2025
bobcallaway
reviewed
Feb 3, 2025
Hayden-IO
reviewed
Feb 3, 2025
Signed-off-by: Ramon Petgrave <ramon.petgrave64@gmail.com>
bobcallaway
approved these changes
Feb 3, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds Windows, Mac, and Ubuntu testing for the cliplugin's
make test-signer-program.https://github.com/sigstore/sigstore/actions/runs/13120139767/job/36603930059#step:4:23
Testing
On Windows, make, mingw and git need to be installed to run the
makecommands.Release Note
Documentation
No new documentation.