Skip to content

Add support for a custom TLS config for clients#2709

Merged
bobcallaway merged 1 commit intosigstore:mainfrom
cmurphy:client-tls
Jan 5, 2026
Merged

Add support for a custom TLS config for clients#2709
bobcallaway merged 1 commit intosigstore:mainfrom
cmurphy:client-tls

Conversation

@cmurphy
Copy link
Contributor

@cmurphy cmurphy commented Jan 3, 2026

Add the ability to set a custom CA or insecure TLS connection in the clients to support connecting to log servers running at an HTTPS instance with a self-signed CA chain.

Relates to sigstore/rekor-monitor#847

Summary

Release Note

Documentation

@cmurphy cmurphy requested a review from a team as a code owner January 3, 2026 00:30
@codecov
Copy link

codecov bot commented Jan 3, 2026

Codecov Report

❌ Patch coverage is 0% with 5 lines in your changes missing coverage. Please review.
✅ Project coverage is 26.15%. Comparing base (488eb97) to head (db2192d).
⚠️ Report is 605 commits behind head on main.

Files with missing lines Patch % Lines
pkg/client/options.go 0.00% 3 Missing ⚠️
pkg/client/rekor_client.go 0.00% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##             main    #2709       +/-   ##
===========================================
- Coverage   66.46%   26.15%   -40.31%     
===========================================
  Files          92      191       +99     
  Lines        9258    20133    +10875     
===========================================
- Hits         6153     5266      -887     
- Misses       2359    14037    +11678     
- Partials      746      830       +84     
Flag Coverage Δ
e2etests 49.65% <0.00%> (+2.09%) ⬆️
unittests 16.67% <0.00%> (-31.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@jku
Copy link
Member

jku commented Jan 5, 2026

both tests seem to have failed with "no space left on device".

(the specific error message is not included in Test harness logs but it shows up in the summary)

@bobcallaway
Copy link
Member

both tests seem to have failed with "no space left on device".

(the specific error message is not included in Test harness logs but it shows up in the summary)

fixed in #2710, this just needs a rebase

Add the ability to set a custom CA or insecure TLS connection in the
clients to support connecting to log servers running at an HTTPS
instance with a self-signed CA chain.

Signed-off-by: Colleen Murphy <colleenmurphy@google.com>
@bobcallaway bobcallaway enabled auto-merge (squash) January 5, 2026 17:33
@bobcallaway bobcallaway merged commit e9d7434 into sigstore:main Jan 5, 2026
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants