Relax gomod#1909
Conversation
Signed-off-by: cpanato <ctadeu@gmail.com>
Signed-off-by: cpanato <ctadeu@gmail.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1909 +/- ##
==========================================
- Coverage 57.93% 49.09% -8.84%
==========================================
Files 50 70 +20
Lines 3119 5204 +2085
==========================================
+ Hits 1807 2555 +748
- Misses 1154 2415 +1261
- Partials 158 234 +76 ☔ View full report in Codecov by Sentry. |
| module github.com/sigstore/fulcio | ||
|
|
||
| go 1.23.4 | ||
| go 1.23.3 |
There was a problem hiding this comment.
we may have to do this again after sigstore/sigstore requirements get dropped and we cut a release?
There was a problem hiding this comment.
I just checked sigstore/sigstore, the version we're using here is on 1.22. @cpanato do you know what's causing the higher requirement?
|
@cpanato I think I found the culprits, https://github.com/chainguard-dev/go-grpc-kit/blob/main/go.mod and https://github.com/chainguard-dev/sdk/blob/main/go.mod. Can these be lowered to 1.22.0? |
|
not sure to be honest, but can check |
Summary
Similar work done in sigstore/rekor#2323
Fixes: #1899