Skip to content

fix: adding ci provider for meta-issuers#1767

Merged
Hayden-IO merged 4 commits intosigstore:mainfrom
javanlacerda:javan.add-ciprovider-for-meta-issuers
Aug 15, 2024
Merged

fix: adding ci provider for meta-issuers#1767
Hayden-IO merged 4 commits intosigstore:mainfrom
javanlacerda:javan.add-ciprovider-for-meta-issuers

Conversation

@javanlacerda
Copy link
Copy Markdown
Contributor

Summary

It set the ci-provider field for meta-issuers

Release Note

Documentation

Signed-off-by: Javan lacerda <javanlacerda@google.com>
@codecov
Copy link
Copy Markdown

codecov Bot commented Aug 15, 2024

Codecov Report

Attention: Patch coverage is 33.33333% with 2 lines in your changes missing coverage. Please review.

Project coverage is 50.31%. Comparing base (cf238ac) to head (f06f32f).
Report is 175 commits behind head on main.

Files Patch % Lines
pkg/identity/ciprovider/principal.go 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1767      +/-   ##
==========================================
- Coverage   57.93%   50.31%   -7.63%     
==========================================
  Files          50       70      +20     
  Lines        3119     4180    +1061     
==========================================
+ Hits         1807     2103     +296     
- Misses       1154     1844     +690     
- Partials      158      233      +75     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Javan lacerda <javanlacerda@google.com>
@javanlacerda javanlacerda force-pushed the javan.add-ciprovider-for-meta-issuers branch from 8432773 to 9389e38 Compare August 15, 2024 17:58
Signed-off-by: Javan lacerda <javanlacerda@google.com>
@javanlacerda javanlacerda force-pushed the javan.add-ciprovider-for-meta-issuers branch from 9389e38 to 8403201 Compare August 15, 2024 18:10
Signed-off-by: Javan lacerda <javanlacerda@google.com>
@Hayden-IO Hayden-IO merged commit 8acbceb into sigstore:main Aug 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants