fix: removing surplus slash, making logs richer#1762
Merged
Hayden-IO merged 3 commits intosigstore:mainfrom Aug 14, 2024
Merged
fix: removing surplus slash, making logs richer#1762Hayden-IO merged 3 commits intosigstore:mainfrom
Hayden-IO merged 3 commits intosigstore:mainfrom
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1762 +/- ##
==========================================
- Coverage 57.93% 50.26% -7.68%
==========================================
Files 50 70 +20
Lines 3119 4166 +1047
==========================================
+ Hits 1807 2094 +287
- Misses 1154 1841 +687
- Partials 158 231 +73 ☔ View full report in Codecov by Sentry. |
d35dcd8 to
9f6f3b4
Compare
Signed-off-by: Javan lacerda <javanlacerda@google.com>
9f6f3b4 to
436ee8e
Compare
Hayden-IO
reviewed
Aug 13, 2024
Signed-off-by: Javan lacerda <javanlacerda@google.com>
8057502 to
89fa77a
Compare
Signed-off-by: Javan lacerda <javanlacerda@google.com>
89fa77a to
0af7abc
Compare
Hayden-IO
approved these changes
Aug 14, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
During the validations, we noticed that the the template for
source-repository-reffor gitlab has a surplus slash.We also noticed that the error with log
"value <> not present in either claims or defaults.has spawned several times in production, but we wasn't able to detect the reason for it, then I decided to put at least the issuer that triggered the flow on the error log.I also added a validation that the metadata should exist for ci-providers.
Release Note
Documentation
cc @haydentherapper