fix: validate buffer bounds in geometry parser#4159
Merged
wellwelwel merged 2 commits intosidorares:masterfrom Mar 8, 2026
Merged
fix: validate buffer bounds in geometry parser#4159wellwelwel merged 2 commits intosidorares:masterfrom
wellwelwel merged 2 commits intosidorares:masterfrom
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #4159 +/- ##
==========================================
+ Coverage 90.40% 90.41% +0.01%
==========================================
Files 86 86
Lines 13954 13977 +23
Branches 1705 1728 +23
==========================================
+ Hits 12615 12638 +23
Misses 1339 1339
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
@wellwelwel awesome thanks for fixing it! If you need help with fixing the rest the findings I mentioned by email, I'll gladly help out :D |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
parseGeometryValuenow checks remaining buffer length before each read.Malformed geometry payloads with inflated point/ring counts previously caused uncaught
RangeErrorcrashes and now returnnull.// eslint-disable-next-line no-case-declarationscomments inparseGeometryValue🙋🏻♂️