fix: add missing charset encoding for UTF8MB4_0900_BIN#3855
Merged
Conversation
- Fix charset_encodings.js array missing index 309 - Resolves "Encoding not recognized: 'undefined'" error
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #3855 +/- ##
==========================================
- Coverage 89.78% 89.76% -0.02%
==========================================
Files 86 86
Lines 13605 13606 +1
Branches 1606 1606
==========================================
- Hits 12215 12214 -1
- Misses 1390 1392 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Collaborator
|
Thanks, @kangsorang ✨ Do you think it's possible to have a test that covers this case (reproducing the failure if it doesn't have your modification)? Perhaps a temporary table with this encoding would solve it. |
Collaborator
|
Thanks again, @kangsorang! I'll include the following test in a new PR to ensure consistency between A and B to prevent that kind of error: import { assert, describe, it } from 'poku';
import mysql from '../../../../index.js';
describe('Charset to Encoding coverage', () => {
const charsets = mysql.Charsets;
const encodings = mysql.CharsetToEncoding;
it('every charset ID should have a defined encoding', () => {
const missing: string[] = [];
const seen = new Set<number>();
for (const [name, id] of Object.entries(charsets)) {
if (typeof id !== 'number' || seen.has(id)) continue;
seen.add(id);
if (encodings[id] === undefined) missing.push(`${name} (id=${id})`);
}
assert.deepStrictEqual(
missing,
[],
`Missing encoding mappings: ${missing.join(', ')}`
);
});
}); |
mdierolf
pushed a commit
to CloudQuote/node-mysql2
that referenced
this pull request
May 23, 2026
- Fix charset_encodings.js array missing index 309 - Resolves "Encoding not recognized: 'undefined'" error Co-authored-by: sorang <sorang@bithumbcorp.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix charset encoding mapping for UTF8MB4_0900_BIN
Problem
MySQL2 throws
Encoding not recognized: 'undefined'error when connecting to MySQL 8.0+ servers usingutf8mb4_0900_bincollation.Root Cause
Mismatch between
charsets.jsandcharset_encodings.js:charsets.jsdefinesUTF8MB4_0900_BIN = 309charset_encodings.jsarray has length 309 (indices 0-308)charset_encodings[309]returnsundefinedIconv.getDecoder(undefined)throws encoding errorSolution
Add missing encoding mapping for index 309 in
charset_encodings.js.Changes
lib/constants/charset_encodings.js'utf8'entry at index 309 forUTF8MB4_0900_BINImpact
utf8mb4_0900_bincollationEncoding not recognized: 'undefined'errors