test: add ErrorAs helper and fix up examples#174
Merged
shoenig merged 6 commits intoshoenig:mainfrom Sep 10, 2024
Merged
Conversation
ccoVeille
reviewed
Sep 9, 2024
ccoVeille
approved these changes
Sep 9, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds an
ErrorAshelper usingerrors.As. I've also been getting intermittent failures from FS examples on WSL, so I changed them to usfstest.MapFSinstead of actual files. And while I was working on that, I noticed that VSCode on Windows was only pretending to run the examples because of their GOOS=unix build constraint, so I applied the constraint to only the examples that needed it.