Merged
Conversation
Owner
|
Actually yeah @alessio-perugini that explicit name form really helps drive home the fact that only the Base is expected - a gotcha that both myself and a coworker fell for 😬 . Since the examples file is already guarded with a |
bce5edc to
7f5df57
Compare
7f5df57 to
f1f124c
Compare
Contributor
Author
Thx for the feedback. You can check the new outcome in the latest commit 🤓 |
shoenig
approved these changes
May 8, 2023
Owner
shoenig
left a comment
There was a problem hiding this comment.
LGTM; thanks again @alessio-perugini!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#123
Yet another day with some more examples 🤓
Lemme know if the example are clear enough I'm not 💯 convinced about
FileContainsFS(t, os.DirFS(os.TempDir()), fName, "bar")might be less clear thanFileContainsFS(t, "/tmp", "fileName, "bar")WDYT?