Merged
Conversation
Contributor
Author
|
@shivammathur, if you can throw me any advice on running the |
Codecov Report
@@ Coverage Diff @@
## master #732 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 6 6
Lines 549 558 +9
Branches 85 90 +5
=========================================
+ Hits 549 558 +9
|
Owner
Contributor
Author
|
Ahh, that's great @shivammathur, thanks!! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
name: ⚙ Improvement: Make PHPUnit versions compatible with the PHP version installed
about: If you just let the
phpunitversion belatest(by not defining a specific version), then it can be incompatible with the version of php defined. This PR fixes that issue.labels: enhancement
A Pull Request should be associated with a Discussion.
Related discussion: #694
Description
This PR makes an improvement to adding
phpunitas a tool. If you just let thephpunitversion belatest(by not defining a specific version), then it can be incompatible with the version of php defined. This PR adds version checking for phpunit and the php being setup.npm run formatbefore the commit.npm run lintbefore the commit.npm run releasebefore the commit.npm testreturns with no unit test errors and all code covered.For those last two points:
The
npm run releasefailed with the following error:I could see no information in the CONTRIBUTION guide as to how to resolve that. I forced the change into the
distfolder so that I could test it out in my own fork.As to the tests: my tests passed just fine. But there were a couple outside of the scope of what I changed that failed - and failed before I even made any changes.
Here's a screenshot of it in practise. I cannot link to the action run as it's a private repo.