fix: use latest in URL when version is empty#1064
Merged
shivammathur merged 1 commit intoshivammathur:mainfrom Mar 4, 2026
Merged
fix: use latest in URL when version is empty#1064shivammathur merged 1 commit intoshivammathur:mainfrom
shivammathur merged 1 commit intoshivammathur:mainfrom
Conversation
When version is not specified (empty string), the getUrl function was generating invalid URLs like /releases/download/cs2pr without any version, which returned 404. This fix ensures that when version is empty or 'latest', the URL includes '/latest/' which GitHub handles correctly with a redirect to the actual latest release. Fixes #1063
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1064 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 8 8
Lines 852 853 +1
Branches 302 303 +1
=========================================
+ Hits 852 853 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Owner
|
@theluckystrike Thanks! |
|
thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1063
When version is not specified (empty string), the getUrl function was generating invalid URLs like without any version, which returned 404.
This fix ensures that when version is empty or 'latest', the URL includes '/latest/' which GitHub handles correctly with a redirect to the actual latest release.
Contributed by theluckystrike | Zovo — Chrome Extension Studio