Merged
Conversation
Currently the changes are all copied from shirou#1364
Contributor
Author
|
I see some github action checks failed, all of which are macos related. After digging into the check details, I couldn't find any relation between the errors and my commits😂️. |
shirou
approved these changes
Sep 30, 2023
Owner
shirou
left a comment
There was a problem hiding this comment.
hmm. dependabot PR also failed with same error, "invalid nice: -10". perhaps some of GitHub image have changed? I will check later.
Anyway, thank you for your great contribution!
I can not confirm it works or not on NetBSD machine, but it seems almost same as FreeBSD, then it should work.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi,
I want to add support for
NetBSDin this PR, where I implement some functions indisk/mem/cpu/host. Though not all functions are implemented, it's a decent start. Thecpupart is largely inspired by the #1364 .I use a
Nano Pi R5Saarch64 board, whereNetBSD 10is running, to test my code, and all the functions I implement can work well there.So can you check this PR to see if it's ok to merge? Thanks.