Skip to content

fix(exec): lockdown file permissions#1060

Merged
nfischer merged 1 commit intomasterfrom
exec-lockdown-perms
Jan 7, 2022
Merged

fix(exec): lockdown file permissions#1060
nfischer merged 1 commit intomasterfrom
exec-lockdown-perms

Conversation

@nfischer
Copy link
Copy Markdown
Member

@nfischer nfischer commented Jan 7, 2022

This locks down file permissions used by the internal implementation of
shell.exec().

Issue #1058
Tested manually using the documented scenarios

This locks down file permissions used by the internal implementation of
`shell.exec()`.

Issue #1058
Tested manually using the documented scenarios
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Jan 7, 2022

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 97.15%. Comparing base (d0a4516) to head (118539f).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1060   +/-   ##
=======================================
  Coverage   97.14%   97.15%           
=======================================
  Files          35       35           
  Lines        1332     1335    +3     
=======================================
+ Hits         1294     1297    +3     
  Misses         38       38           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@nfischer nfischer merged commit 003a39d into master Jan 7, 2022
@nfischer nfischer deleted the exec-lockdown-perms branch January 7, 2022 05:14
nfischer added a commit that referenced this pull request Jan 7, 2022
This locks down file permissions used by the internal implementation of
`shell.exec()`.

Issue #1058
Tested manually using the documented scenarios
@nfischer nfischer linked an issue Jan 7, 2022 that may be closed by this pull request
@nfischer nfischer added this to the v0.8.5 milestone Jan 7, 2022
jchip pushed a commit to jchip/shcmd that referenced this pull request Jun 23, 2024
This locks down file permissions used by the internal implementation of
`shell.exec()`.

Issue shelljs#1058
Tested manually using the documented scenarios
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Trying to get in touch regarding a security issue

2 participants