Removed mentions of documentup website #1056
Merged
nfischer merged 2 commits intoshelljs:masterfrom Dec 17, 2021
Merged
Conversation
Contributor
Author
|
This was also discussed in issue 1049: #1049 |
Codecov Report
@@ Coverage Diff @@
## master #1056 +/- ##
=======================================
Coverage 97.14% 97.14%
=======================================
Files 35 35
Lines 1332 1332
=======================================
Hits 1294 1294
Misses 38 38 Continue to review full report at Codecov.
|
nfischer
approved these changes
Dec 15, 2021
Contributor
Author
|
Thanks for approving my pull request! It seems that merging is blocked due to the requirement for all signed commits. Do I need to rebase and resign my commits to merge this pull request? Thanks :) |
Member
|
Ah, my apologies. I was just waiting for the unit tests to pass but forgot to come back to this. All looks good! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since documentup website is no longer available, I have removed all mentions of it in README.md and RELEASE.md
Current documentation is generated using
npm run gendocsto pull annotated comments and append in README.md.npm testandnpm run lintpassed.Let me know if you have any questions.