Hmm for some reason it looks like the coverage report isn't changing for mkdir.js: https://app.codecov.io/gh/shelljs/shelljs/compare/1026. Do you know why this condition doesn't appear to be covered?

It looks like appveyor is not reporting coverage info, as Windows-specific code doesn't appear to have coverage. This must be a codecov or appveyor bug though.

Thank you for looking at this PR and for creating this project!

I'm not sure on the appveyor/Windows part, but after looking at the code block above, and investigating/logging with npm run test-with-coverage, I learned that no tests currently trigger those lines. Although I would've thought the mkdir -p test on an existing subdirectory might have, it appears this _mkdir function returns that test case early here before we can get to the mkdirSyncRecursive function call:

To check this, if I re-write that line on my local branch as if (!options.fullpath || (options.fullpath && stat.isFile())) return; then the test coverage goes up (although not to perfect 100s everywhere for mkdir). There is also possibly some duplicated logic where even with that fix we still never reach inside this if statement:

Should I add to this PR (by changing shelljs/src/mkdir.js), or possibly file another issue or PR to increase the test coverage?

I see, thanks for looking into this. Let's land this as-is because it adds useful test coverage. If you can think of a way to de-duplicate the logic, that would be a welcome contribution in a separate PR!

Thank you!