Skip to content

Fix incompatible pointer type passed to GEOSPolygonize_r#1945

Merged
jorisvandenbossche merged 1 commit intoshapely:mainfrom
musicinmybrain:incompatible-pointer-type
Dec 4, 2023
Merged

Fix incompatible pointer type passed to GEOSPolygonize_r#1945
jorisvandenbossche merged 1 commit intoshapely:mainfrom
musicinmybrain:incompatible-pointer-type

Conversation

@musicinmybrain
Copy link
Copy Markdown
Contributor

@musicinmybrain musicinmybrain commented Dec 3, 2023

Fixes the following warning by improving const-correctness:

  src/ufuncs.c: In function ‘polygonize_func’:
  src/ufuncs.c:2205:51: warning: passing argument 2 of ‘GEOSPolygonize_r’ from incompatible pointer type [-Wincompatible-pointer-types]
   2205 |     GEOSGeometry* ret_ptr = GEOSPolygonize_r(ctx, geoms, n_geoms);
        |                                                   ^~~~~
        |                                                   |
        |                                                   GEOSGeometry ** {aka struct GEOSGeom_t **}
  In file included from src/geos.h:15,
                   from src/ufuncs.c:16:
  /usr/include/geos_c.h:979:31: note: expected ‘const GEOSGeometry * const*’ {aka ‘const struct GEOSGeom_t * const*’} but argument is of type ‘GEOSGeometry **’ {aka ‘struct GEOSGeom_t **’}
    979 |     const GEOSGeometry *const geoms[],
        |     ~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~

With Fedora Linux’s PortingToModernC initiative, further described in this mailing list message, this warning will become an error.

@coveralls
Copy link
Copy Markdown

coveralls commented Dec 3, 2023

Pull Request Test Coverage Report for Build 7078121549

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.3%) to 88.019%
Totals Coverage Status
Change from base Build 6898857040: 0.3%
Covered Lines: 2586
Relevant Lines: 2938
💛 - Coveralls

@thesamesam
Copy link
Copy Markdown

thesamesam commented Dec 4, 2023

FWIW, I still see:

src/ufuncs.c: In function ‘Ydd_b_p_func’:
src/ufuncs.c:436:23: warning: passing argument 2 of ‘func’ discards ‘const’ qualifier from pointer target type [-Wdiscarded-qualifiers]
  436 |       ret = func(ctx, prepared_geom_tmp, in2, in3);
      |                       ^~~~~~~~~~~~~~~~~
src/ufuncs.c:436:23: note: expected ‘void *’ but argument is of type ‘const GEOSPreparedGeometry *’ {aka ‘const struct GEOSPrepGeom_t *’}

but that's less of an issue.

jorisvandenbossche
jorisvandenbossche reviewed Dec 4, 2023
View reviewed changes
@musicinmybrain
Copy link
Copy Markdown
Contributor Author

musicinmybrain commented Dec 4, 2023

FWIW, I still see:

I agree; I still see several other warnings that it would be nice to fix. This PR only targets the “incompatible pointer type” warning.

@jorisvandenbossche jorisvandenbossche merged commit 0545588 into shapely:main Dec 4, 2023
@jorisvandenbossche
Copy link
Copy Markdown
Member

jorisvandenbossche commented Dec 4, 2023

Thanks!

This was referenced Aug 20, 2024
Merged
Closed
jorisvandenbossche pushed a commit that referenced this pull request Aug 20, 2024
@musicinmybrain @jorisvandenbossche
Fix incompatible pointer type passed to GEOSPolygonize_r (#1945)
a2d37eb
@mwtoews mwtoews mentioned this pull request Oct 17, 2024
Closed
@FliegendeWurst FliegendeWurst mentioned this pull request Nov 21, 2024
Merged
2 tasks
This was referenced Jan 15, 2025
Closed
Closed
@jorisvandenbossche jorisvandenbossche mentioned this pull request Jan 29, 2025
Closed
@fmigneault fmigneault mentioned this pull request Jan 31, 2025
Closed
@theroggy theroggy added this to the 2.1 milestone Feb 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jorisvandenbossche jorisvandenbossche jorisvandenbossche approved these changes

+1 more reviewer

@thesamesam thesamesam thesamesam left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

2.1

Development

Successfully merging this pull request may close these issues.

5 participants

@musicinmybrain @coveralls @thesamesam @jorisvandenbossche @theroggy