PEM parsing: check last error instead of first#2148
Merged
alex merged 1 commit intorust-openssl:masterfrom Jan 11, 2024
Merged
Conversation
Collaborator
|
Hmm, my impression when I wrote that code is that Using last seems to presume other errors will be added there after the no start line error. |
b38b9a5 to
0bbc215
Compare
Contributor
Author
|
It uses |
Regression introduced in rust-openssl#2120. Ideally, tests would not leave other errors behind. Fixes rust-openssl#2146
0bbc215 to
aa26e97
Compare
Collaborator
|
😱. We probably should make that unambigiously clear in the docs. But for now: thank you! |
alex
approved these changes
Jan 11, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Regression introduced in #2120. Ideally, tests would not leave other errors behind.
Fixes #2146