fix(G602): avoid false positives for range-over-array indexing#1531
Merged
ccojocar merged 1 commit intosecurego:masterfrom Feb 19, 2026
Merged
fix(G602): avoid false positives for range-over-array indexing#1531ccojocar merged 1 commit intosecurego:masterfrom
ccojocar merged 1 commit intosecurego:masterfrom
Conversation
This change fixes a false positive in G602 when iterating over fixed-size arrays with range and indexing using the loop variable. Corrects loop bound normalization in SSA-based index analysis so offsets are not applied twice. Preserves true-positive detection for real out-of-bounds patterns (for example index + 1 at upper edge). Adds regression samples covering both: valid range-over-array indexing (no issue expected) invalid shifted indexing inside the same loop (issue expected) Signed-off-by: Cosmin Cojocar <cosmin@cojocar.ch>
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1531 +/- ##
=======================================
Coverage 80.08% 80.09%
=======================================
Files 101 101
Lines 9175 9198 +23
=======================================
+ Hits 7348 7367 +19
- Misses 1382 1384 +2
- Partials 445 447 +2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change fixes a false positive in G602 when iterating over fixed-size arrays with range and indexing using the loop variable.
fixes #1525