Support for regular expressions with #[IgnoreDeprecations] attribute#6341
Merged
sebastianbergmann merged 1 commit intosebastianbergmann:mainfrom Sep 23, 2025
Merged
Conversation
82e35f3 to
8a5c9a3
Compare
| return true; | ||
| } | ||
|
|
||
| public function shouldIgnore(string $message): bool |
There was a problem hiding this comment.
I am not comfortable with the fact that a value object, which is what a Metadata object is supposed to be, makes a decision like that.
This decision should be moved to ErrorHandler::deprecationIgnoredByTest(), for example.
Contributor
Author
There was a problem hiding this comment.
done.
I must mention that I did the same thing in IgnorePhpunitWarnings: https://github.com/sebastianbergmann/phpunit/blob/main/src/Metadata/IgnorePhpunitWarnings.php#L40
do you want that I change that too?
There was a problem hiding this comment.
Yes, please. This should be a separate PR to the 12.3 branch. Thanks!
8a5c9a3 to
8ab4448
Compare
8ab4448 to
afea22c
Compare
#[IgnoreDeprecations]
#[IgnoreDeprecations]#[IgnoreDeprecations] attribute
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This will allow to only ignore specific deprecations, instead of all of them