#[IgnorePHPUnitWarnings] attribute for ignoring PHPUnit warnings#6268
Merged
sebastianbergmann merged 3 commits intosebastianbergmann:mainfrom Jul 8, 2025
Merged
Conversation
nikophil
commented
Jul 7, 2025
966ce2c to
0e6020d
Compare
Owner
Looks good, thank you. I will merge once you're ready. |
5b7a797 to
226a7c3
Compare
| { | ||
| if ( | ||
| $test->isTestMethod() && | ||
| class_exists($test->className()) && |
Owner
There was a problem hiding this comment.
Is the call to class_exists() really needed? I do not see how we could have a Code\Test $test object where $test->className() returns a string that is not the name of a class that exists.
Contributor
Author
There was a problem hiding this comment.
I've added it because the test DispatchingEmitterTest::testTestTriggeredPhpunitWarningEmitsTestPhpunitWarningTriggeredEvent uses a classname that does not exist
Contributor
Author
There was a problem hiding this comment.
I think that otherwise, we should use existing classes/methods here
226a7c3 to
c14fba9
Compare
nikophil
commented
Jul 8, 2025
c2ef009 to
735d011
Compare
Contributor
Author
|
@sebastianbergmann ready! 😊 |
#[IgnorePHPUnitWarnings]#[IgnorePHPUnitWarnings] attribute for ignoring PHPUnit warnings
Owner
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a follow up PR of this discussion
I hope the involved complexity is not too high. I was actually pleasantly surprised how easy it was
Please, could you tell me what's your feeling about the implementation, if you're okay to go, I'll add some missing unit tests.
thanks!