TestDox result collector does not correctly handle baseline-ignored E_DEPRECATED issues#5977
Closed
pcf0 wants to merge 1 commit intosebastianbergmann:11.4from
pcf0:testTriggeredPhpDeprecation
Closed
TestDox result collector does not correctly handle baseline-ignored E_DEPRECATED issues#5977pcf0 wants to merge 1 commit intosebastianbergmann:11.4from pcf0:testTriggeredPhpDeprecation
E_DEPRECATED issues#5977pcf0 wants to merge 1 commit intosebastianbergmann:11.4from
pcf0:testTriggeredPhpDeprecation
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## 11.4 #5977 +/- ##
=========================================
Coverage 94.68% 94.68%
Complexity 6762 6762
=========================================
Files 713 713
Lines 20396 20396
=========================================
Hits 19312 19312
Misses 1084 1084 ☔ View full report in Codecov by Sentry. |
E_DEPRECATED issues
Owner
|
Cherry-picked into |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When comparing versions 11.3.6...11.4.0, I noticed the change from commit f36e89b.
I think in the method
testTriggeredPhpDeprecationthe wrong line was deleted?