Ignore suppression when generating baseline#5887
Merged
sebastianbergmann merged 1 commit intosebastianbergmann:10.5from Jul 23, 2024
Merged
Ignore suppression when generating baseline#5887sebastianbergmann merged 1 commit intosebastianbergmann:10.5from
sebastianbergmann merged 1 commit intosebastianbergmann:10.5from
Conversation
82bbbf3 to
969f390
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## 10.5 #5887 +/- ##
============================================
+ Coverage 93.84% 94.07% +0.23%
- Complexity 6363 6571 +208
============================================
Files 677 699 +22
Lines 19286 19796 +510
============================================
+ Hits 18099 18624 +525
+ Misses 1187 1172 -15 ☔ View full report in Codecov by Sentry. |
969f390 to
b45f0cd
Compare
Contributor
Author
|
some of these lines are hard to cover, lmk if I need to do more |
Contributor
|
Hi! 💯 for this PR I tried it and works perfectly. Before the PR: After the PR, the baseline is fully created. |
b45f0cd to
81325a6
Compare
Owner
|
Please target the |
81325a6 to
d2e49f4
Compare
This was referenced Jul 25, 2024
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If an event is suppressed, while generating the baseline, we only checked for
ignoreSuppressionOfPhpWarningsalthough we should check every option.