Simplify NamePrettifier::prettifyTestMethodName()#5744
Merged
sebastianbergmann merged 1 commit intosebastianbergmann:10.5from Mar 12, 2024
Merged
Simplify NamePrettifier::prettifyTestMethodName()#5744sebastianbergmann merged 1 commit intosebastianbergmann:10.5from
NamePrettifier::prettifyTestMethodName()#5744sebastianbergmann merged 1 commit intosebastianbergmann:10.5from
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## 10.5 #5744 +/- ##
============================================
- Coverage 90.08% 90.08% -0.01%
Complexity 6436 6436
============================================
Files 680 680
Lines 19533 19532 -1
============================================
- Hits 17597 17596 -1
Misses 1936 1936 ☔ View full report in Codecov by Sentry. |
NamePrettifier::prettifyTestMethodName()
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
remove a unnecessary function call in a hot path. additionally I think its more readable now.