Skip to content

Micro-optimize TestRunner::runTestWithTimeout()#5740

Closed
staabm wants to merge 1 commit intosebastianbergmann:mainfrom
staabm:size
Closed

Micro-optimize TestRunner::runTestWithTimeout()#5740
staabm wants to merge 1 commit intosebastianbergmann:mainfrom
staabm:size

Conversation

@staabm
Copy link
Copy Markdown
Contributor

@staabm staabm commented Mar 12, 2024

the function call is showing up in blackfire profiles of blackfire run php ./phpunit --testsuite unit

grafik

@sebastianbergmann sebastianbergmann added type/performance Issues related to resource consumption (time and memory) version/10 Something affects PHPUnit 10 version/11 Something affects PHPUnit 11 labels Mar 12, 2024
@sebastianbergmann
Copy link
Copy Markdown
Owner

Cherry-picked into 10.5 and merged to 11.0 and main from there. Thanks!

@staabm
Copy link
Copy Markdown
Contributor Author

staabm commented Mar 12, 2024

should I target future performance PRs directly to 10.5 ?

@staabm staabm deleted the size branch March 12, 2024 07:27
@sebastianbergmann
Copy link
Copy Markdown
Owner

If they also apply to 10.5 then yes, please. Thanks!

@sebastianbergmann sebastianbergmann added the feature/test-runner CLI test runner label Mar 12, 2024
@sebastianbergmann sebastianbergmann changed the title Micro optimize TestRunner->runTestWithTimeout() Micro-optimize TestRunner::runTestWithTimeout() Mar 12, 2024
@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Apr 18, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

feature/test-runner CLI test runner type/performance Issues related to resource consumption (time and memory) version/10 Something affects PHPUnit 10 version/11 Something affects PHPUnit 11

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants