assertArrayIsIdenticalToArrayOnlyConsideringListOfKeys() does not correctly handle array order#5729
Merged
sebastianbergmann merged 1 commit intosebastianbergmann:11.0from Mar 10, 2024
Conversation
Follow up on 5716. Sorry, I screwed up. While the fix in 5716 correctly fixes the handling of array keys to be in line with PHP itself, it broke the differentiation between `isEqual` and `isIdentical` as the arrays were now being recreated in the order of the keys passed to the `$keysToBeConsidered` parameter. This is not problematic for the `assertArrayIsEqualToArrayOnlyConsideringListOfKeys()` assertion as the array order is not relevant there. However, it is problematic for the `assertArrayIsIdenticalToArrayOnlyConsideringListOfKeys()` assertion, where the array order is relevant. This commit fixes it. Includes unit test safeguarding the fix. And while the `assertArrayIs*ToArrayIgnoringListOfKeys()` assertions are not affected, I've also included a unit test for the issue for those assertions, just to be on the safe side.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## 11.0 #5729 +/- ##
============================================
- Coverage 89.95% 89.95% -0.01%
+ Complexity 6464 6460 -4
============================================
Files 683 683
Lines 19591 19586 -5
============================================
- Hits 17624 17619 -5
Misses 1967 1967 ☔ View full report in Codecov by Sentry. |
assertArrayIsIdenticalToArrayOnlyConsideringListOfKeys() does not correctly handle array order
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow up on #5716.
Sorry, I screwed up.
While the fix in #5716 correctly fixes the handling of array keys to be in line with PHP itself, it broke the differentiation between
isEqualandisIdenticalas the arrays were now being recreated in the order of the keys passed to the$keysToBeConsideredparameter.This is not problematic for the
assertArrayIsEqualToArrayOnlyConsideringListOfKeys()assertion as the array order is not relevant there.However, it is problematic for the
assertArrayIsIdenticalToArrayOnlyConsideringListOfKeys()assertion, where the array order is relevant.This commit fixes it.
Includes unit test safeguarding the fix.
And while the
assertArrayIs*ToArrayIgnoringListOfKeys()assertions are not affected, I've also included a unit test for the issue for those assertions, just to be on the safe side.