fix: consider timeout from hyper::Error#2742
Merged
seanmonstar merged 1 commit intoseanmonstar:masterfrom Jun 23, 2025
Merged
Conversation
Owner
|
Thanks for the PR! I'm guessing there was an instance you ran into because of this. Have you been able to test it out with a local patch override in your Cargo.toml? |
Contributor
Author
|
Yes. I replace pub trait ErrorExt {
...
+ fn is_timeout2(&self) -> bool;
}
@@ -64,6 +69,13 @@ impl ErrorExt for reqwest::Error {
})
}
+ fn is_timeout2(&self) -> bool {
+ self.is_timeout()
+ || (self.is_request()
+ && get_source_error_type::<hyper::Error>(self)
+ .is_some_and(hyper::Error::is_timeout))
+ }
+Some background: the request error happens when the iOS phone turns on/off airplane mode, but
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I tried to push down
std::io::ErrorKind::TimedOutintohyper::error::TimedOut's source, but failed (due to the referenceddyn Error). So I does here instead.And another minor change: the test case didn't cover
ErrorKind::TimedOutbranch.