Skip to content

Update RuboCop#818

Merged
sds merged 1 commit intosds:mainfrom
andyw8:andyw8/update-rubocop-version
Jan 15, 2024
Merged

Update RuboCop#818
sds merged 1 commit intosds:mainfrom
andyw8:andyw8/update-rubocop-version

Conversation

@andyw8
Copy link
Contributor

@andyw8 andyw8 commented Jan 10, 2024

The current version of Ruby is from April 2020. Since there are quite a lot of new issues identified, I've committed them to the .rubocop_todo.yml so that they can be addressed incrementally or disabled.


# Pin RuboCop for Travis builds.
gem 'rubocop', '0.82.0'
# Pin RuboCop for CI builds
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changed since it looks like Travis is no longer used.

context 'when phpcs fixer exits successfully with fixed file' do
before do
# rubocop:disable Metrics/LineLength
# rubocop:disable Layout/LineLength
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

RuboCop has changed the category of this cop.

@andyw8 andyw8 marked this pull request as ready for review January 10, 2024 16:22
@sds sds merged commit faf76fc into sds:main Jan 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants