MAINT: Fix typo, make nbstripout work with pre-commit #3760
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jl-wynen
reviewed
Sep 3, 2025
| types: [ "jupyter" ] | ||
| args: [ "--drop-empty-cells", | ||
| "--extra-keys 'metadata.language_info.version cell.metadata.jp-MarkdownHeadingCollapsed cell.metadata.pycharm'" ] | ||
| "--extra-keys=metadata.language_info.version cell.metadata.jp-MarkdownHeadingCollapsed cell.metadata.pycharm" ] |
Member
There was a problem hiding this comment.
Good catch!
Does this still use all 3 keys? I would expect that it needs quotation marks around them.
Member
Author
There was a problem hiding this comment.
It catches jp-Markdown in docs/getting-started/tutorials/solar_flares.ipynb in the diff so I guess it works fine without quotes.
jl-wynen
approved these changes
Sep 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3246
There was a typo in setting up the config and pre-commit wasn't running the correct config for nbstripout.