MAINT: remove vscode settings from git #3758
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
So we didn't want to remove the settings.json file? |
Member
Author
This PR removes it, and that's what I understood from #3580. |
nvaytet
approved these changes
Sep 12, 2025
Member
nvaytet
left a comment
There was a problem hiding this comment.
Sorry I misread the diff (it looks different on my phone)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3580
I did not add this to our developer docs as it will one more thing to make sure is kept up to date. I don't think we need to do that. Everyone is free to create their own local setup, and we .gitignore all vscode specific things.