Fix hist to preserve unrelated coord in multi-dim cases
#3530
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
I had a quick look at tools to detect unused variables.
But ruff and vulture do find an unused variable if it's name is not reused. E.g. in def foo(x: list[int]) -> list[int]:
asd = [2 * i for i in x]
drop = [1, 2, 3]
return dropthey correctly flag |
jl-wynen
approved these changes
Sep 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a bug in a newly introduced feature in #3501. Previously it was not possible to get into such a case because
histdid not support this mode of operation.Looking at the diff in that PR
it is evident that I had begun changing the code, but then keep the old way of computing
drop. I wonder if there is a static analysis tool that could catch something like this (thedropdefined on line 579 is unused)? Isn't it in some sense similar to an "unused argument" check?