feat: add drop_coords and masks to bins #3518
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
There was a suggestion in the original issue to not add a new method to But I decided to not do that for now, since then it would not be possible to drop only the inner coords. |
SimonHeybrock
approved these changes
Aug 13, 2024
Member
|
Can you also use this addition in the place linked in the issue? |
src/scipp/core/binning.py
Outdated
Comment on lines
421
to
425
| if x.bins is None: | ||
| x = x.drop_coords(drop) | ||
| else: | ||
| content = x.bins.constituents | ||
| content['data'] = content['data'].drop_coords(drop) | ||
| x = x.copy(deep=False) | ||
| x.data = _cpp._bins_no_validate(**content) | ||
| x = x.bins.drop_coords(drop) | ||
| return x |
Member
There was a problem hiding this comment.
Isn't this just return da.drop_coords(drop) (see the alias da defined in line 418)?
614a4d3 to
cd80efc
Compare
cd80efc to
f4655cd
Compare
SimonHeybrock
approved these changes
Aug 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3496