fix: treat base is zero case specially #3515
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
I wasn't able to locate where we test the values / variances of arithmetic operations. |
Member
These should generally all be here: https://github.com/scipp/scipp/blob/main/lib/core/test/value_and_variance_test.cpp. If there is more logic in the kernel than implemented in |
Comment on lines
74
to
75
| const auto pow_0 = (base.value == 0 && exponent >= 0 && exponent < 1) | ||
| ? 0 |
Member
There was a problem hiding this comment.
- Shouldn't 0**0 give 1?
- Why do we need the
exponent < 1, or the sign check? Isn't it just zero everywhere if the base is zero (except of the exponent also is)?
Contributor
Author
There was a problem hiding this comment.
- Good catch.
- Yeah that's probably right, it's unnecessary to check if
exponent < 1. But we need to check the sign because if exponent is negative the result should benanand not0.
88fb96d to
46e7f56
Compare
SimonHeybrock
approved these changes
Aug 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3507
I think most of the cases in the issue are fine except:
because in those cases the value of the result should just be
0.0and notnan.