Skip to content

Use pybind11 from ConanCenter, remove local recipe #3487

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
MridulS merged 2 commits into from
Jun 26, 2024
Merged

Use pybind11 from ConanCenter, remove local recipe #3487

MridulS merged 2 commits into from
Jun 26, 2024

Conversation

@MridulS
Copy link
Member

@MridulS MridulS commented Jun 26, 2024

(First trying to clean up some things before upgrading to conan2)

We don't need to have a local recipe, https://conan.io/center/recipes/pybind11?version=2.12.0 can be used directly.

I tried the build locally with remote pybind11 and tests do pass fine locally.

Requirements
    LLNL-Units/0.9.1 from local cache - Cache
    benchmark/1.6.1 from 'conancenter' - Cache
    boost/1.79.0 from 'conancenter' - Cache
    eigen/3.4.0 from 'conancenter' - Cache
    gtest/1.11.0 from 'conancenter' - Cache
    pybind11/2.12.0 from 'conancenter' - Cache

@MridulS
Copy link
Member Author

MridulS commented Jun 26, 2024

I'll merge this, if something does go wrong we should know tomorrow with the nightlies.

@MridulS MridulS enabled auto-merge (squash) June 26, 2024 13:10
@MridulS MridulS merged commit 30d6533 into scipp:main Jun 26, 2024
@MridulS MridulS deleted the conan2 branch June 27, 2024 08:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@SimonHeybrock SimonHeybrock SimonHeybrock approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@MridulS @SimonHeybrock