Update to macos-14 CI images #3484
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Btw I can confirm I get the ctest error on my local arm based Mac too. |
Member
Author
|
@MridulS can you dig into this to find out where the discrepancy comes from? I am surprised to see a size change here. |
Member
Author
|
Actually, I think I know what is happening. All failing tests are related to short string optimisation. This was bound to fail eventually... |
Member
Author
|
Tests pass. I will update the branch protection rules once the PR is accepted. |
MridulS
approved these changes
Jun 24, 2024
fc544af to
087c138
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3481.
This uses
macos-14in PRs which is an arm64 machine. I think this makes sense as the number of M1 and M2 machines is only increasing. See https://github.com/actions/runner-images