Appease mypy some more #3474
Merged
Appease mypy some more #3474
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
src/scipp/core/bins.py
Outdated
| class Constituents(TypedDict): | ||
| """A dict with bin constituents.""" | ||
|
|
||
| data: Variable | DataArray |
src/scipp/core/bins.py
Outdated
| begin: Variable | ||
| """Begin indices for each bin.""" | ||
| end: Variable | ||
| """Begin indices for each bin.""" |
Member
There was a problem hiding this comment.
Suggested change
| """Begin indices for each bin.""" | |
| """End indices for each bin.""" |
src/scipp/core/bins.py
Outdated
| """A dict with bin constituents.""" | ||
|
|
||
| data: Variable | DataArray | ||
| """Buffer with events.""" |
Member
There was a problem hiding this comment.
Suggested change
| """Buffer with events.""" | |
| """Data content""" |
avoid "events", since that is Neutron terminology.
src/scipp/io/hdf5.py
Outdated
Comment on lines
237
to
247
| DType.float64, | ||
| DType.float32, | ||
| DType.int64, | ||
| DType.int32, | ||
| DType.bool, | ||
| DType.datetime64, | ||
| DType.vector3, | ||
| DType.linear_transform3, | ||
| DType.rotation3, | ||
| DType.translation3, | ||
| DType.affine_transform3, |
Member
There was a problem hiding this comment.
Same as in reader_lut above?
src/scipp/visualization/colors.py
Outdated
|
|
||
|
|
||
| def make_random_color(fmt='rgb'): | ||
| def make_random_color( |
Member
There was a problem hiding this comment.
Is this still used? Remnant from plotting in Scipp, pre-dating Plopp?
Member
Author
There was a problem hiding this comment.
No, it isn't. I removed it now.
SimonHeybrock
approved these changes
Jun 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.