Drop support for Python 3.9 #3441
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MridulS
reviewed
May 7, 2024
| matrix: | ||
| os: [ubuntu-22.04] | ||
| build: [cp39, cp310] | ||
| build: [cp310] |
Member
Author
There was a problem hiding this comment.
We only build the oldest version here for tests of the other packages. We had both 3.9 and 3.10 to support the migration period which is now (hopefully) ending.
Member
There was a problem hiding this comment.
Wouldn't hurt to add 3.11 I suppose? Maybe we can drop 3.10 early in projects that do not need Mantid?
Member
Author
There was a problem hiding this comment.
Could do. But I'd do that separately. It already takes a long time to test this PR.
Member
Author
|
All green. I'll update the branch protection rules when the PR is approved. |
MridulS
approved these changes
May 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This only changes the version constraints / selections. I will open a separate PR for pyupgrade (
ruff check --select=UP) to keep this one here easier to review.