fix: masks not applied correctly in curve_fit #3436
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
SimonHeybrock
left a comment
There was a problem hiding this comment.
Please edit the issue title so it is clear which function(s) are affected.
src/scipp/curve_fit.py
Outdated
Comment on lines
214
to
216
| combined_mask = zeros(dims=fda.data.dims, shape=fda.data.shape, dtype='bool') | ||
| for m in fda.masks.values(): | ||
| fda = fda[~m] | ||
| combined_mask |= m |
Member
There was a problem hiding this comment.
Could use
scipp/src/scipp/core/concepts.py
Line 75 in b05655b
SimonHeybrock
approved these changes
May 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously masks were not applied in a correct way.
The old version had a bug that made it only work if there was only one mask per dimension.