Skip to content

Require identical units in mod operation #3404

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
nvaytet merged 4 commits into from
Mar 5, 2024
Merged

Require identical units in mod operation #3404

nvaytet merged 4 commits into from
Mar 5, 2024

Conversation

@nvaytet
Copy link
Member

@nvaytet nvaytet commented Mar 4, 2024 •
edited
Loading

Fixes #3402

Note that:

sc.scalar(4., unit='m') % sc.scalar(3., unit='m')  # works
sc.scalar(4., unit='m') % sc.scalar(3., unit='s')  # raises
sc.scalar(4., unit='m') % 3.  # raises
sc.scalar(4.) % 3.  # works

i.e. dimensionless can work with bare numbers.

SimonHeybrock
SimonHeybrock reviewed Mar 4, 2024
View reviewed changes
lib/units/unit.cpp Outdated
Comment on lines 134 to 135
throw except::UnitError("Cannot perform modulo operation with " + a.name() +
" and " + b.name() + ".");
Copy link
Member

@SimonHeybrock SimonHeybrock Mar 4, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mention that units must match?

@nvaytet nvaytet merged commit 59ef5df into main Mar 5, 2024
@nvaytet nvaytet deleted the mod-require-same-units branch March 5, 2024 09:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@SimonHeybrock SimonHeybrock SimonHeybrock approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

scipp.mod ignores the divisor's units

3 participants

@nvaytet @SimonHeybrock