Reduce memory consumption in asv benchmark runs #3307
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some benchmarks were failing with exit status -9. This *might* fix it. The benchmarks seemed to be using close to 4 GByte RAM, which gets close to the 7 GByte available on the GitHub hosted runners.
jl-wynen
reviewed
Nov 3, 2023
Member
jl-wynen
left a comment
There was a problem hiding this comment.
It still allocated the full data array. So the question is, is the peak memory consumption in setup or in the timing functions?
Did you run the benchmarks on this branch?
Member
Author
|
Yes I ran it and it reduced the memory consumption. |
jl-wynen
approved these changes
Nov 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some benchmarks were failing with exit status -9. This might fix it. The benchmarks seemed to be using close to 4 GByte RAM, which gets close to the 7 GByte available on the GitHub hosted runners.