Remove deprecated HDF5 functions #3300
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nvaytet
reviewed
Oct 23, 2023
| return HDF5IO.read(f) | ||
|
|
||
|
|
||
| def to_hdf5(obj: VariableLike, filename: Union[str, Path]) -> None: |
Member
There was a problem hiding this comment.
As the CI says, you forgot to update the imports. Not sure if API reference also needs updating?
Otherwise, looks good.
nvaytet
reviewed
Oct 23, 2023
src/scipp/io/__init__.py
Outdated
| from .hdf5 import load_hdf5 | ||
|
|
||
| __all__ = ["load_csv", "load_hdf5", "open_hdf5", "to_hdf5"] | ||
| __all__ = ["load_csv", "load_hdf5"] |
Member
There was a problem hiding this comment.
Do we also need to make save_hdf5 available?
Member
Author
There was a problem hiding this comment.
I don't think anyone uses it as a free function. But I guess that would make sense.
nvaytet
approved these changes
Oct 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.