Support integer weights in hist and remove dtype limitations
#3298
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nvaytet
reviewed
Oct 23, 2023
| Values{19, 12, 12})); | ||
| } | ||
|
|
||
| TEST_F(Histogram1DTest, int64_weights) { |
Member
Author
There was a problem hiding this comment.
What about the other 10+ cases? What would we gain?
See also discussion in #3251.
Co-authored-by: Neil Vaytet <39047984+nvaytet@users.noreply.github.com>
nvaytet
approved these changes
Nov 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3126.
As discussed in the linked issue, directly supporting all possible dtype combinations would require a very large number of template instantiations. With the change here I am converting to the common type of coord and edges, which avoid this. We thus have only
4*4+1*4 = 20cases. Otherwise it would be4*4*4+1*4 = 68.This adds
common_type, which may be useful for other applications. Maybe it would even be worth exposing to Python?Unrelated, I got a lot of compiler warnings about passing
std::string_viewby value, which apparently even made compilation fail with our current settings. I added references everywhere.