Prevent integer overflow in variances #3262
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nvaytet
reviewed
Oct 2, 2023
| } | ||
| template <class T1, class T2> | ||
| constexpr auto operator/(const ValueAndVariance<T1> a, const T2 b) noexcept { | ||
| return ValueAndVariance{a.value / b, a.variance / (b * b)}; |
Member
There was a problem hiding this comment.
Would it be possible instead to use a trick like the order of operations above?
e.g. return ValueAndVariance{a.value / b, a.variance / b / b};?
Member
Author
There was a problem hiding this comment.
It would be. But this would trade a multiplication for a division. So it would be slightly more expensive. But I don't know if that matters. Should I change it?
Member
There was a problem hiding this comment.
Should I change it?
I don't mind, your call. Tradeoff between performance and code simplicity.
Member
Author
There was a problem hiding this comment.
The other code needs a comment, so it's not necessarily simpler :-)
nvaytet
approved these changes
Oct 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3236