fix: consider vscode dark mode #3260
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
9bb7a48 to
a0e397e
Compare
jl-wynen
reviewed
Sep 26, 2023
| --sc-table-header-font-color: $header_text_color; | ||
| } | ||
|
|
||
| html[theme=dark], |
Member
There was a problem hiding this comment.
This also selects non-vs-code elements. Did you check that this doesn't affect Jupyter notebook / lab?
Also, should we even apply these variables outside of .sc-root?
Contributor
Author
There was a problem hiding this comment.
You're right. It's better to only keep the last path.
a0e397e to
f3833ca
Compare
Contributor
Author
|
Screenshots from light-vscode, dark-vscode and light-jupyter respectively. |
Member
|
What about dark mode in jupyter? |
Contributor
Author
Checked that before but did not make a screenshot.
|
jl-wynen
approved these changes
Sep 26, 2023
f3833ca to
2ab85db
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3170.
Fix borrowed from https://github.com/pydata/xarray/blob/da647b06312bd93c3412ddd712bf7ecb52e3f28b/xarray/static/css/style.css#L16.